Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Deprecate TopPage classes which are being renamed #1251

Conversation

emteknetnz
Copy link
Member

Issue #1240

@emteknetnz emteknetnz force-pushed the pulls/5/deprecate-top-page-classes branch from 99ca48d to 9eecdb9 Compare September 5, 2024 00:12
@emteknetnz emteknetnz changed the title API Deprecate TopPage classes which are being moved API Deprecate TopPage classes which are being renamed Sep 5, 2024
@emteknetnz emteknetnz force-pushed the pulls/5/deprecate-top-page-classes branch from 9eecdb9 to 2410220 Compare September 5, 2024 00:15
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli
Copy link
Member

Will merge once we've got 5.3.0-beta1 out of the way of the 5 branch.

@GuySartorelli GuySartorelli merged commit b923eae into silverstripe:5 Sep 9, 2024
24 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/deprecate-top-page-classes branch September 9, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants